Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid annotations on supertype #1068

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Forbid annotations on supertype #1068

wants to merge 3 commits into from

Conversation

Ao-senXiong
Copy link
Member

Fixes #1059

@Ao-senXiong Ao-senXiong requested a review from wmdietl January 22, 2025 19:52
@Ao-senXiong Ao-senXiong mentioned this pull request Jan 24, 2025
Open
@Ao-senXiong
Copy link
Member Author

Ao-senXiong commented Jan 28, 2025 •
edited
Loading

@wmdietl Should we also forbid annotation on supertype's type parameter? For example

public static class NullSupplier extends Supplier<@Nullable String> {}

nvm, looks like there is a reason we should allow annotation on supertype's type parameter. https://eisop.github.io/cf/manual/manual.html#annotations-are-a-contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl Awaiting requested review from wmdietl

Assignees

@wmdietl wmdietl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forbid annotations on class extends and implements clauses
2 participants
@Ao-senXiong @wmdietl