Specify sampling rate for actors

[hughsimpson]

No description provided.

[janm399]

We could probably use foreach. The effect will be the same, but the name map is a bit loaded.

[janm399]

I think it's time to refactor the def accept(actorPath: ActorPath, actorClassName: Option[String]): Boolean into something that composes a bit better. I've seen it duplicated in this PR too often; the duplication is either pretty obvious (same name and params) or slightly hidden (viz includes and accept).

Let's tidy that up.

[janm399]

This should probably be in the subclass. I'm beginning to think that the abstract aspect might not be needed at all.

[janm399]

This is looking much better. The only thing is that the sampling rate skews the actual number of messages. You send the actor 1000 messages with sampling rate 5, but the counter value is only 200. It should read 1000, but with 5 increments.

There's a whole bunch of missing ScalaDoc, unused imports, and the naming of the tests does not really match the existing tests.

Finally, the WithUnhandledActor.scala contains too many actors. It may be worth pulling all test actors into one file, for example actors.scala

[janm399]

Nice! I didn't know about that @unchcked annotation.

[janm399]

Looking good. Just a few last bits to tidy up and we're good to merge.

[janm399]

I pulled the latest code. Sbt builds properly, scalastyle reports no errors. That is actually a problem, because PathAndClass is still missing documentation and the Scaladoc for ActorFilter.accept is not correct. (Even the IDE shows it in red!)

The code in the ActorCellMonitoringAspect is good, but you should pay attention to the code style. All fields are accessed using this., for example:

        if (!this.agentConfiguration.incuded().accept(pathAndClass)) return false;
        if (this.agentConfiguration.excluded().accept(pathAndClass)) return false;

        if (this.agentConfiguration.includeSystemAgents()) return true;

Your code misses out this., making it look untidy. (Viz lines 69, 77, 78.)

---

Looking further, remember our rule to leave the place in a better state than it was when you found it. So, the documentation on the advices is poor. It repeats the documentation of the pointcut, but doesn't really explain what the advice does.

[janm399]

As a result of the code review, we have two improvement issues: #59 and #60.