Skip to content

Commit

Permalink
Fix Flask version warning
Browse files Browse the repository at this point in the history
  • Loading branch information
andriilahuta committed Jan 29, 2024
1 parent 3da892d commit fb0bce9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 2 additions & 3 deletions logstash_async/formatter.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# of the MIT license. See the LICENSE file for details.

from datetime import date, datetime
import importlib.metadata
import logging
import socket
import sys
Expand Down Expand Up @@ -438,9 +439,7 @@ def __init__(self, *args, **kwargs):

# ----------------------------------------------------------------------
def _fetch_flask_version(self):
# pylint: disable-next=import-error,import-outside-toplevel,no-name-in-module
from flask import __version__
self._flask_version = __version__
self._flask_version = importlib.metadata.version('flask')

# ----------------------------------------------------------------------
def _get_extra_fields(self, record):
Expand Down
6 changes: 2 additions & 4 deletions tests/formatter_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from logging import FileHandler, makeLogRecord
from types import SimpleNamespace
from unittest.mock import patch
import importlib.metadata
import os
import socket
import sys
Expand Down Expand Up @@ -354,10 +355,7 @@ class FlaskTestMixin:
@classmethod
def setUpClass(cls): # pylint: disable=invalid-name
super().setUpClass()

# pylint: disable-next=import-outside-toplevel,no-name-in-module
from flask import __version__
cls.flask_version = __version__
cls.flask_version = importlib.metadata.version('flask')

def _create_request(self):
return SimpleNamespace(
Expand Down

0 comments on commit fb0bce9

Please sign in to comment.