-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abs
and make Oliver's example work
#702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good but one of your rules seems unsound
@@ -214,6 +247,35 @@ | |||
((set (hi-bound lhs) (BoolB (bool-< la hb)))) | |||
:ruleset interval-analysis) | |||
|
|||
; Abs | |||
|
|||
; absolute value is non-negative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not true 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, you just have to fix CI
Look over the snapshots for our example carefully!
Output bril:
SVGs
Before
After