Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: make substitution strictly class-level, update tools #645

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

donn
Copy link
Member

@donn donn commented Jan 22, 2025

  • OpenROAD.Floorplan

    • Fixed an issue in FP_SIZING: absolute mode where if the die area's
      x0 > x1 or y0 > y1, the computed core area would no longer fit in the die
      area. Not that we recommend you ever do that, but technically OpenROAD
      allows it.

Tool Updates

  • Updated nix-eda
    • Updated nixpkgs to nixos-24.11 (@ 3c53b4b)
    • Updated KLayout to 0.29.10
    • Updated Magic to 8.3.515
    • Updated Netgen to 1.5.291
  • Updated OpenROAD to 655640a
    • Adds new DFT features
  • Updated Volare to 0.20.5
    • Includes support for ihp-sg13g2

Misc. Enhancements/Bugfixes

  • openlane.flows

    • SequentialFlow
      • Substitutions are now to be strictly consumed by the subclass initializer,
        i.e., it can no longer be done on the object-level and only on the class
        level. Additionally, it can provided as a list of tuples instead of a
        dictionary so the same key may be reused multiple times.
      • Step IDs are re-normalized after every substitution, so a substitution for
        OpenROAD.DetailedPlacement-1 for example would always refer to the
        second OpenROAD.DetailedPlacement AFTER applying all previous
        substitutions, instead of the second "original"
        OpenROAD.DetailedPlacement in the flow.
  • openlane.config

    • meta.substituting_steps now only apply to the sequential flow declared in
      meta.flow and not all flows.

Resolves #646

@donn donn requested a review from kareefardi January 22, 2025 10:42
@donn donn marked this pull request as ready for review January 23, 2025 10:30
@openlane-bot
Copy link
Collaborator

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • Changes to critical metrics were detected in the following designs:
    • gf180mcuD/gf180mcu_fd_sc_mcu7t5v0/usb_cdc_core
    • gf180mcuD/gf180mcu_fd_sc_mcu7t5v0/wbqspiflash
    • gf180mcuD/gf180mcu_fd_sc_mcu7t5v0/zipdiv
    • sky130A/sky130_fd_sc_hd/EF_PSRAM_CTRL_V2
    • sky130A/sky130_fd_sc_hd/MS_DMAC_AHBL
    • sky130A/sky130_fd_sc_hd/MS_SPI_XIP_CACHE

Full tables ► https://gist.github.com/openlane-bot/860ccacf224d00f945c02a11b04e4991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants