Fix counter_wb test & Makefile cocotb-verify-* regex #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algofoogle
commented
Dec 12, 2024
There was a problem hiding this comment.
A group review between @marwaneltoukhy, @DavidRLindley and @algofoogle determined this was ready to merge.
@DavidRLindley I can't self-approve. Can you approve this PR?
NOTE: I believe the failing tests in the GitHub Actions are either a known problem still to be fixed about these repos generally, or are due to an upstream repo that needs its own fix first, and not a fault of this particular commit.
DavidRLindley
approved these changes
Dec 12, 2024
|
I'm not authorized to merge, Anton. I looked over the changes and don't see anything obvious, but asked Marwan to review, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 things:
cocotb-verify-*in Makefile prevents running any test that ends in the letterc.gitignoreupdated to excludevenv-cocotb(per venv-cocotb should be in .gitignore #373 ).