ci2504 dev #565
Open
ci2504 dev #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added deleted targets with a message stating that the target has been deleted. - Removed openlane/README.rst before creating to prevent outdated version on error. - Corrected .RECIPE keyword to .PHONY - Corrected python check message to correct version.
- Sort manifest files - Handle compressed files in master_manifest
- set_user_id had no dependencies - gen_gpio_defaults had a dependency for caravan_core.mag, but added a smart_open routine to natively open an uncompressed or compressed file based on the suffix. No need to recompress.
Fixed PHONY syntax error
- Added message saying the lvs-* recipes may be out-of-date and have limited support. - Removed redundant BLOCKS calculation - Renamed lvs-* to lvs-mag-* to avoid conflicts with user_project Makefiles
- Uncompress caravel_core/caravan_core.mag if compressed. - Add mcw path to compose_final.tcl. - Return magic exit code.
…to ci2504-DEV manifest sort order differences across Linux distros.
Development does not create oas files, so not tested on development data.
d-mitch-bailey
requested review from
algofoogle,
donn,
a-omla,
marwaneltoukhy and
DavidRLindley
DavidRLindley
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile related updates
Updated manifest recipes.
Removed background recipes.
Removed unused COMMIT variables.
Replaced recipes for unused targets with messages that the targets were not supported.
Added unspilt targets.
Changed uncompress dependencies to unspilt where necessary.
Allow volare installation from user directories.
Standardize manifest output across distress.
Added check-gpio-id target for oasis data.
Updated final target to handle uncompressed files.