Fix update setup info #415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add default keyword argument block=True in update_setup_info and not only when status is in info Thsi is done because PyWelocme in order to update the task_idx with update_setup_info and we want to make sure it is done before open the window for starting the experiment. Also by adding makes it more clear when the block is used or not
when skipping use logging to show which keys are missing from the table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add default keyword argument block=True in update_setup_info and not only when status is in info
This is done because PyWelcome in order to update the task_idx with update_setup_info and we want to make sure it is done before open the window for starting the experiment.
Also use logging for the skipping tables and show which keys are missing from the table and is being skipped