Retrieval of additional properties from GND #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrRataplan
reviewed
Nov 26, 2024
| @@ -100,6 +103,18 @@ export class GND extends Registry { | |||
| if (json.professionOrOccupation && json.professionOrOccupation.length > 0) { | |||
| output.profession = json.professionOrOccupation.map((prof) => prof.label); | |||
| } | |||
| if (json.preferredNameEntityForThePerson && json.preferredNameEntityForThePerson.length > 0) { | |||
| json.preferredNameEntityForThePerson.map((fullName) => { | |||
There was a problem hiding this comment.
nit: the return of the map is not used. can be a forEach.
Same with the other map
There was a problem hiding this comment.
Also, the function is marked as async, but the await keyword is not used. I'd take a second and rewrite it to async/await which is more readable imho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.