[MST-1473] Proctoring Service Launch #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelRoytman
force-pushed
the
mroytman/MST-1473-proctoring-service-launch
branch
from
0f7f81b to
a8140fc
Compare
MichaelRoytman
force-pushed
the
mroytman/MST-1473-proctoring-service-launch
branch
6 times, most recently
from
007210c to
1487d6b
Compare
ashultz0
reviewed
Oct 26, 2022
ashultz0
reviewed
Oct 26, 2022
ashultz0
reviewed
Oct 26, 2022
| ) | ||
|
|
||
| # These claims are optional. | ||
| # TODO: This will need to have additional consideration for PII. |
There was a problem hiding this comment.
Question: I'm guessing that this todo is addressed below?
There was a problem hiding this comment.
We aren't sending over any PII for proctoring in this implementation anymore, so I have removed the TODO. We can add it back in after things are ironed out with product and legal.
edx_exams/apps/lti/views.py
Outdated
| lti_config = LtiConfiguration.objects.get(id=lti_config_id) | ||
|
|
||
| proctoring_launch_data = Lti1p3ProctoringLaunchData( | ||
| # TODO: This is incorrect. It should be an integer starting at 1 and increasing by 1 for each subsequent |
There was a problem hiding this comment.
Question: So this still needs to be addressed correct? Just a placeholder I'm assuming?
There was a problem hiding this comment.
I will replace exam_attempt.id with exam_attempt.attempt_number, per Zach's comment, which will address this. I'll remove the TODO.
zacharis278
reviewed
Nov 1, 2022
|
liking how simple this actually is on the exams side 👍 |
MichaelRoytman
force-pushed
the
mroytman/MST-1473-proctoring-service-launch
branch
6 times, most recently
from
1ce4519 to
dae276f
Compare
MichaelRoytman
force-pushed
the
mroytman/MST-1473-proctoring-service-launch
branch
4 times, most recently
from
ca5f4fd to
12a227a
Compare
ashultz0
approved these changes
Nov 16, 2022
This commit updates the sample LTI proctoring integration to use the new LTI launch refactor in xblock-lti-consumer (openedx/xblock-lti-consumer#288) and the Proctoring Services implementation (openedx/xblock-lti-consumer#297). As a reminder, this application currently serves as a mock implementation of the proctoring flow to demonstrate how we might use the xblock-lti-consumer library for proctoring. It is not intended to be deployed as-is or to serve as an actual proctoring flow implementation. Here is a digest of important changes. * The launch_proctoring, start_assessment, public_keyset, and access_token views are removed. * The start_proctoring and end_assessment views are added. * A signal handler for the LTI_1P3_PROCTORING_ASSESSMENT_STARTED is added. * The lti AppConfig is modified to support the above signal.
MichaelRoytman
force-pushed
the
mroytman/MST-1473-proctoring-service-launch
branch
from
12a227a to
31ac0db
Compare
MichaelRoytman
deleted the
mroytman/MST-1473-proctoring-service-launch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: MST-1473
Description:
This pull request updates the sample LTI proctoring integration to use the new LTI launch refactor in xblock-lti-consumer and the proposed Proctoring Services implementation.
As a reminder, this application currently serves as a mock implementation of the proctoring flow to demonstrate how we might use the xblock-lti-consumer library for proctoring. It is not intended to be deployed as-is or to serve as an actual proctoring flow implementation.
Changes:
Here is a digest of important changes.
launch_proctoring,start_assessment,public_keyset, andaccess_tokenviews are removed.start_proctoringandend_assessmentviews are added.LTI_1P3_PROCTORING_ASSESSMENT_STARTEDis added.AppConfigis modified to support the above signal.Testing Instructions:
In your local checkout of edx-exams, set the following settings in
edx_exams/settings/local.py.The requirements files should be pointing at the correct branch of xblock-lti-consumer and should install it correctly. If there are problems, check out the xblock-lti-consumer library locally and pip install it. If the proposed Proctoring Services implementation is still on a branch, check out the branch an install it.
Log in to the edx-exams service using the ngrok URL -
<NGROK_URL>/admin. The reason it's important to log in via the ngrok URL is to ensure that the session cookie is set on the proper domain so that the cookie is included by the browser when the Tool makes requests to the NGROK_URL. If you log in through localhost, then when the Tool makes requests to the NGROK_URL, the user will be the AnonymousUser. This will cause the flow to fail.Set up the Proctoring Certification Suite 1.0.
Create a new LtiConfiguration instance in the edx-exams admin panel.
The process of setting this testing suite up is very similar to the existing instructions for testing LTI 1.3 launches in the xblock-lti-consumer README. Use that as a reference. Instead of setting the data on the XBlock, set it on the LtiConfiguration in the admin panel. Instead of setting the data in the LTI 1.3 launch testing tool, set it in the Proctoring Certification Suite 1.0.
In your browser, hit the following URL to start the LTI proctoring flow:
<NGROK_URL>/lti/start_proctoring/1. 1 represents the database ID for the LtiConfiguration, so set it appropriately if you have more than one LtiConfiguration you're testing with.Description:
This pull request uses the Proctoring Service implementation in a branch of
xblock-lti-consumerto demonstrate a proctoring launch using LTI.Author concerns:
The bulk of the code is in the associated pull request. Most of my concerns are in that repository.
Dependencies:
Merge checklist:
Post merge: