Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to quince #8

Merged
merged 1 commit into from
Jun 3, 2024
Merged

feat: add support to quince #8

merged 1 commit into from
Jun 3, 2024

Conversation

Henrrypg
Copy link
Contributor

Description

This PR adds support to quince version.

In this version is not necessary any fork or custom change in mfes.

For now, tutor-mfe does not have released the version that includes mfe-dockerfile-final patch.

To use this plugin before the release, is needed to install master branch.

@Henrrypg Henrrypg requested a review from MoisesGSalas January 29, 2024 20:52
@Henrrypg Henrrypg marked this pull request as draft January 29, 2024 21:03
@MoisesGSalas
Copy link
Member

MoisesGSalas commented Apr 5, 2024

@Henrrypg, would you mind checking this PR again whenever you have time considering v17.0.1 is released?

@Henrrypg Henrrypg marked this pull request as ready for review April 8, 2024 13:31
Copy link
Member

@MoisesGSalas MoisesGSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that we should probably include the tutor version supported here (https://github.com/eduNEXT/tutor-contrib-mfe-extensions/blob/master/setup.py#L42) and also add the minimum version for tutor-mfe (17.0.1)

README.md Outdated Show resolved Hide resolved
@MoisesGSalas MoisesGSalas merged commit 6811d69 into master Jun 3, 2024
@MoisesGSalas MoisesGSalas deleted the hpg/quince-support branch June 3, 2024 22:38
@MoisesGSalas MoisesGSalas restored the hpg/quince-support branch December 20, 2024 01:33
@MoisesGSalas MoisesGSalas deleted the hpg/quince-support branch December 20, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants