Skip to content

Commit

Permalink
fix: dummy select should be updated by the side effect as well
Browse files Browse the repository at this point in the history
  • Loading branch information
edmundhung committed Aug 3, 2024
1 parent 3830c59 commit 045e40f
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions packages/conform-react/integrations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export function getEventTarget(

export function createDummySelect(
form: HTMLFormElement,
key: Key | null | undefined,
name: string,
value?: string | string[] | undefined,
): HTMLSelectElement {
Expand All @@ -71,7 +72,7 @@ export function createDummySelect(

select.name = name;
select.multiple = true;
select.dataset.conform = 'true';
select.dataset.conform = `${key ?? 'true'}`;

// To make sure the input is hidden but still focusable
select.setAttribute('aria-hidden', 'true');
Expand All @@ -98,7 +99,7 @@ export function createDummySelect(
export function isDummySelect(
element: HTMLElement,
): element is HTMLSelectElement {
return element.dataset.conform === 'true';
return typeof element.dataset.conform !== 'undefined';
}

export function updateFieldValue(
Expand Down Expand Up @@ -345,7 +346,7 @@ export function useInputControl<
typeof value !== 'undefined' &&
(!Array.isArray(value) || value.length > 0)
) {
element = createDummySelect(form, meta.name, value);
element = createDummySelect(form, meta.key, meta.name, value);
}

register(element);
Expand Down

0 comments on commit 045e40f

Please sign in to comment.