Support edgeql files with snake_case
#661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
force-pushed
the
655-support-snake-edgeql
branch
from
eef1c2d to
3d2d63a
Compare
scotttrinh
added a commit
that referenced
this pull request
Apr 15, 2024
This reverts commit 4c428e7. This change was too breaking in the form we introduced here, so revert and follow up with a better way to map filenames to function names.
scotttrinh
added a commit
that referenced
this pull request
Apr 15, 2024
This reverts commit 4c428e7. This change was too breaking in the form we introduced here, so revert and follow up with a better way to map filenames to function names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python codegen expects snake_case, which kinda makes sense as a standard to adopt for EdgeQL related identifiers, so this adds support for
_as a word separator.NOTE: This is strictly speaking a breaking change since if you had snake case names before you were importing
foo_queryand now it'll befooQuery, but I'm hoping this is ok to break for better alignment with multi-language repos.I'm going to leave this PR open for a bit and gather some feedback about the breaking nature of this: we can wait for a major version bump if this is disruptive!
Before:
After:
Closes #655