fix: rework optimistic indexer attempts #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theodus
force-pushed
the
theodus/indexing-status
branch
from
b8ee423 to
a9d7e3e
Compare
Theodus
force-pushed
the
theodus/indexing-status
branch
from
a9d7e3e to
2de9e82
Compare
Theodus
force-pushed
the
theodus/indexing-status
branch
from
2de9e82 to
fd10161
Compare
Theodus
changed the title
LNSD
approved these changes
Nov 28, 2023
| @@ -935,6 +897,32 @@ pub fn indexer_fee( | |||
| } | |||
| } | |||
|
|
|||
| async fn optimistic_query( | |||
There was a problem hiding this comment.
Nit: A small description of this function will be very helpful for the future Theo and Lorenzo 🙂
Theodus
force-pushed
the
theodus/indexing-status
branch
from
fd10161 to
b4c678e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gateway was originally designed with the assumption that each indexer would likely remain about as many blocks behind chain head as when it last reported its status. However, this is no longer a valid assumption when supporting file data sources and chains with wildly inconsistent block rates. This replaces the pile of spaghetti I've created to cope with these issues with something much more straightforward. Now indexer candidates are selected based on their last reported block and the last reported block is used for the deterministic query. For each selection, under some conditions we will first make an optimistic attempt at a block 2 seconds behind chain head.