fix: avoid retaining uncled blocks in cache #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theodus
force-pushed
the
theodus/block-cache
branch
from
a9a5389 to
6e47430
Compare
Theodus
changed the title
Merged
Theodus
added a commit
that referenced
this pull request
Dec 18, 2023
I have no evidence that this has caused issues. But it seems like a potentially nasty bug on chains that produce blocks more frequently than we poll for chain heads, since we may miss uncles. Seems like a good precaution anyway. The performance impact should be minimal because we deduplicate RPC requests on cache miss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no evidence that this has caused issues. But it seems like a potentially nasty bug on chains that produce blocks more frequently than we poll for chain heads, since we may miss uncles. Seems like a good precaution anyway. The performance impact should be minimal because we deduplicate RPC requests on cache miss.