refactor: move fee selection out of indexer selection #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! 🎉 |
Theodus
force-pushed
the
theodus/budget-take2
branch
from
22ce858 to
541a798
Compare
Merged
Theodus
added a commit
that referenced
this pull request
Dec 18, 2023
This removes Agora (and therefore GraphQL-specific) cost models from indexer-selection. The fee negotiation step now happens before indexer selections (and no longer requires a retry). For now, the interaction between budgeting & candidate fees is simple, but that's acceptable for now since we are paying indexers more than they are requesting. Volume discounting has been removed entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Agora (and therefore GraphQL-specific) cost models from indexer-selection. The fee negotiation step now happens before indexer selections (and no longer requires a retry). For now, the interaction between budgeting & candidate fees is simple, but that's acceptable for now since we are paying indexers more than they are requesting. Volume discounting has been removed entirely.