Feature request: action to copy username (and possibly other, arbitrary, fields) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add action `username' on the key `u', to copy the contents of the entry's "username" field (if it has one) to the kill ring. If there is no such field, nothing is copied. Fixes ecraven#6.
Hugo-Heagren
added a commit
to Hugo-Heagren/ivy-pass
that referenced
this pull request
Jul 16, 2021
Add action `choose field' on the key `c', to copy the contents of an chosen one of the entry's fields to the kill ring. See also the second point in ecraven#6.
calancha
reviewed
Aug 8, 2021
ivy-pass.el
Outdated
| @@ -88,6 +91,10 @@ Default PASSWORD-LENGTH is ‘password-store-password-length’." | |||
| "Add username for KEY to kill ring." | |||
| (password-store-copy-field key "username")) | |||
|
|
|||
| (defun ivy-pass--choose-field-action (key) | |||
| "Choose a field from KEY's entry and copy its value to kill ring." | |||
| (password-store-copy-field (password-store-read-field key))) | |||
There was a problem hiding this comment.
The first arg. is missing:
(password-store-copy-field key (password-store-read-field key)))
There was a problem hiding this comment.
The first arg. is missing:
Thanks. Fixed.
Add action `choose field' on the key `c', to copy the contents of an chosen one of the entry's fields to the kill ring. See also the second point in ecraven#6.
Hugo-Heagren
force-pushed
the
username-action
branch
from
1cfa389 to
87834b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used to use pass.el, but I've recently switched to ivy-pass. The only feature I miss is the ability to copy the
usernamefield from a pass entry. It doesn't seem too difficult to implement.Thinking about it, and looking at the code, it would be easy and possibly useful to implement copying arbitrary fields from an entry too. I'm thinking that an action like
copy-arbitrary-fieldwould just invoke a new ivy completion over the fields of the entry, excluding the password, which could then be copied as usual.