feat(ECO-2876): Add arena candlesticks to SDK #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CRBl69
changed the title
xbtmatt
reviewed
Feb 27, 2025
There was a problem hiding this comment.
I would be extra safe with this and not include it in any of the existing Period stuff, neither types nor the enum. In it should be typed differently than the other periods, because it's not a contract type. It will make it fairly annoying to work with, but if it's included in the existing types, TypeScript won't warn us about some functions breaking (that should break)
They're just used in so many different places and there are assumptions in a few places on the number of periods. (check calculatePeriodBoundariesCrossed, and in general a few of the utility/conversion functions that were missed at the bottom of sdk/src/const.ts)
Honestly, it might be a little difficult to properly add it in, so I'm okay if you remove them entirely. Although they would be really nice to have, especially for testing, I think they might be a little too difficult to add properly.
I apologize for suggesting we use them without fully thinking it through, there's just so many places you'd need to update it to get it working. It won't fail until you run the frontend, either...
We can discuss on call tomorrow, too
xbtmatt
reviewed
Mar 3, 2025
Co-authored-by: Matt <[email protected]>
…s candlestick tests
xbtmatt
approved these changes
Mar 4, 2025
alnoki
approved these changes
Mar 4, 2025
xbtmatt
approved these changes
Mar 4, 2025
xbtmatt
added a commit
that referenced
this pull request
Mar 5, 2025
…and README to support `arena` (#565) [ECO-2785] Update event types across the SDK and frontend to support broker-emitted arena events (#566) [ECO-2786] Add e2e tests for all arena websocket events except `Melee` events (#567) [ECO-2789] Update the broker image version for the `alpha` stack to use `5.0.1`: arena event emission support (#568) [ECO-2664] Add home page arena update (#508) Co-authored-by: Matt <[email protected]> [ECO-2588] Add market page banner and navigation link to arena (#512) Co-authored-by: Matt <[email protected]> [ECO-2802] Fix minor import issue (#576) [ECO-2807] Have the `deployer` service start a very short arena; add tests to set next melee duration (#579) [ECO-2812] Kill stacks (#586) [ECO-2809] Restrict number of lines changed in a PR (#582) [ECO-2816] Deploy arena stack (#590) [ECO-2801] Attempt to properly rebase arena feature branch (#575) Co-authored-by: Bogdan Crisan <[email protected]> [ECO-2815] Update SDK according to processor changes (#589) [ECO-2828] Add shadcn styles to `global.css` for prototyping (#593) [ECO-2811] Bump processor submodule; add/separate SDK test commands for arena; change skip to page; add arena routes to `ROUTES` (#585) ci(ECO-2840): Add conventional commit check (#607) feat(ECO-2837): Add configurable arena indexing (#608) ci(ECO-2482): Disable submodule check when PR not to main (#610) chore(ECO-2843): Update stack deploy files (#611) fix(ECO-2845): Don't try to parse user agent string if it's empty (#613) chore(ECO-2844): Revive stack deploy files (#612) fix(ECO-2846): Remove the blur on hover effect for performance and UX reasons (#614) chore(ECO-2847): Remove disabling arena indexing override (#616) [ECO-2813] Add a `/test-utils` page for updating arena state on a local network; add shadcn for prototyping components (#587) test(ECO-2808): Add E2E tests for arena processor refactor (#581) Co-authored-by: Matt <[email protected]> chore(ECO-2851): Clean up `PrivateChart.tsx` and make the inner logic more modular (#618) [ECO-2826] Add happy path indexer testing for enter, swap, and exit (#591) Co-authored-by: Matt <[email protected]> fix(ECO-2853): Fix object comparison in e2e tests that accidentally got merged (#621) test(ECO-2827): Add arena leaderboard testing (#592) Co-authored-by: Matt <[email protected]> ci(ECO-2855): Add GitHub actions merge queue support (#622) docs(ECO-2860): Document emojicoin arena audit (#625) ci(ECO-2870): Update docs site build to run each PR (#627) fix(ECO-2848): Update `next.config.mjs` `experimental.staleTimes` to remove opinionated default caching behavior (#617) chore(ECO-2880): Simplify PR template for conventional commits (#631) test(ECO-2887): Update loop test declaration per Aptos Labs guidance (#632) chore(ECO-2875): Miscellaneous clean-up and stylistic fixes for consistency (#630) chore(ECO-2889): Kill `arena` stack in preparation for cold upgrade (#634) chore(ECO-2891): Revive `arena` stack with `v6.0.0-alpha.1` versions (#635) chore(ECO-2857): Update SDK to match new processor fields (#624) Co-authored-by: Matt <[email protected]> chore(ECO-2888): Bump arena `processor` submodule to `v6.0.0-alpha.1`; build corresponding new `broker` image (#633) test(ECO-2835): Test leaderboard exit status (#605) Co-authored-by: Matt <[email protected]> test(ECO-2862): Add missing test cases for arena processing (#626) Co-authored-by: Matt <[email protected]> feat(ECO-2876): Add arena candlesticks to SDK (#640) Co-authored-by: Matt <[email protected]> chore(ECO-2956): Prepare the `alpha` stack for revival by killing it (#670) chore(ECO-2957): Revive the `alpha` stack with `6.0.0` (#671)
xbtmatt
added a commit
that referenced
this pull request
Mar 5, 2025
Co-authored-by: Matt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the SDK with the new candlestick types.
It adds types for the
arena_candlesticktable.