[ECO-2710] Force display the "Go to emojicoin market" button on the launch emojicoin page regardless of wallet connection or being geoblocked #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xbtmatt
changed the title
GO TO EMOJICOIN MARKET on the launch emojicoin page e…
xbtmatt
changed the title
alnoki
approved these changes
Jan 28, 2025
…ven when the user wallet isn't connected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The go to emojicoin market button doesn't show up if the user isn't connected with their wallet or if they're geoblocked. This can be fixed by adding a simple "forceDisplayChildren" prop to the ConnectWalletButtonFallback, with the conditional set to whether or not the market is registered already.
BEFORE CHANGE:
AFTER CHANGE (see wallet is definitively not connected in the top right):
Testing
Delete this sentence and provide a description of how to test the changes in
this PR.
Checklist