-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-2700] Clean up environment variables, fix documentation, remove unused frontend
container in Docker
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xbtmatt
requested review from
alnoki and
CRBl69
and removed request for
alnoki
January 25, 2025 04:10
alnoki
reviewed
Jan 25, 2025
CRBl69
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff to fix.
Also, I don't personally use it but is there a reason to remove the frontend from docker compose ? Never mind, just read the PR description.
Format Format/cspell
…ion, update `prune.sh` and `README.md` Delete action Leave the frontend-tests in, actually
…ld time in vercel.
Simplify env files, add filler env var for GRPC_AUTH_TOKEN
CRBl69
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Docker container for the
frontend
service had a ton of repeated variables that made the environment variable files look huge, so I removed it because we never use it (we disabled the frontend tests).I left the frontend testing code in there in case we ever do want to use it again- just removed the option to run a frontend container in Docker, since it was unnecessary and made the code/configuration for Docker needlessly confusing.
I updated all the env files to have a corresponding network and sample values, so that it's easy to run very quickly.
Testing
Run through the examples manually to see if it actually works.
For
local
network:testnet
:And it should work with the locally running testnet emojicoin indexer.
Checklist