Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2700] Clean up environment variables, fix documentation, remove unused frontend container in Docker #522

Merged
merged 9 commits into from
Jan 29, 2025

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Jan 25, 2025

Description

The Docker container for the frontend service had a ton of repeated variables that made the environment variable files look huge, so I removed it because we never use it (we disabled the frontend tests).

I left the frontend testing code in there in case we ever do want to use it again- just removed the option to run a frontend container in Docker, since it was unnecessary and made the code/configuration for Docker needlessly confusing.

I updated all the env files to have a corresponding network and sample values, so that it's easy to run very quickly.

Testing

Run through the examples manually to see if it actually works.

For local network:

# Navigate to `src/docker` and run:
pnpm run docker:prune
cd src/docker
docker compose -f compose.local.yaml --env-file example.local.env up -d

# Run the frontend for localnet
cd src/typescript
mv example.local.env .env
pnpm run dev
  • Test on localnet

testnet:

# For testnet:
pnpm run docker:prune
cd src/docker
docker compose -f compose.yaml --env-file example.testnet.env up -d

# Run the frontend for testnet
cd src/typescript
cp example.testnet.env .env
pnpm run dev
  • Test it for testnet
  • Test it for mainnet as well

And it should work with the locally running testnet emojicoin indexer.

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check all checkboxes from the linked Linear task?

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ❌ Failed (Inspect) Jan 29, 2025 7:19pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:19pm

Copy link
Collaborator

@CRBl69 CRBl69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff to fix.

Also, I don't personally use it but is there a reason to remove the frontend from docker compose ? Never mind, just read the PR description.

src/docker/README.md Show resolved Hide resolved
src/docker/example.testnet.env Show resolved Hide resolved
Simplify env files, add filler env var for GRPC_AUTH_TOKEN
@alnoki alnoki enabled auto-merge (squash) January 29, 2025 19:17
@alnoki alnoki merged commit 90bd596 into main Jan 29, 2025
6 of 7 checks passed
@alnoki alnoki deleted the ECO-2700 branch January 29, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants