Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2669] Fix the aliased path resolution issues in the TypeScript SDK #511

Merged
merged 15 commits into from
Feb 1, 2025
Merged

[ECO-2669] Fix the aliased path resolution issues in the TypeScript SDK #511

merged 15 commits into from
Feb 1, 2025

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Jan 19, 2025 •
edited
Loading

Description

The paths aren't aliasing properly in the TypeScript SDK. We need to fix it or the SDK is unusable.

Testing

  • Pushing to the npm registry and testing the SDK as an external developer.

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check all checkboxes from the linked Linear task?

@xbtmatt xbtmatt added urgency-low Can check after high/medium urgency size-small A small PR. This can be reviewed and merged fast. labels Jan 19, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 11:27pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 11:27pm

@xbtmatt xbtmatt marked this pull request as ready for review January 31, 2025 23:15
@xbtmatt
Cspell
707a3a4 
Add ability to specify API key for the emojicoin client

Update pnpm lock.yaml
@xbtmatt xbtmatt requested a review from CRBl69 January 31, 2025 23:24
@alnoki alnoki merged commit ab1e412 into main Feb 1, 2025
7 checks passed
@alnoki alnoki deleted the ECO-2669 branch February 1, 2025 00:30
alnoki pushed a commit that referenced this pull request Feb 4, 2025
@xbtmatt @alnoki
[ECO-2669] Fix the aliased path resolution issues in the TypeScript S…
4e2012b 
…DK (#511)
@alnoki alnoki mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alnoki alnoki alnoki approved these changes

@CRBl69 CRBl69 Awaiting requested review from CRBl69

Assignees
No one assigned
Labels
size-small A small PR. This can be reviewed and merged fast. urgency-low Can check after high/medium urgency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xbtmatt @alnoki