Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2664] Add home page arena update #508

Merged
merged 6 commits into from
Feb 10, 2025
Merged

[ECO-2664] Add home page arena update #508

merged 6 commits into from
Feb 10, 2025
+556 −26

Conversation

CRBl69
Copy link
Collaborator

@CRBl69 CRBl69 commented Jan 16, 2025

Description

This PR updates the home page for the new arena feature.

Testing

See home page.

Checklist

  • Did you check all checkboxes from the linked Linear task?

Sorry, something went wrong.

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 4:10am
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 4:10am

@CRBl69 CRBl69 marked this pull request as ready for review January 17, 2025 18:47
@CRBl69 CRBl69 requested a review from xbtmatt January 17, 2025 18:47
@CRBl69 CRBl69 added the urgency-high Please check first label Jan 21, 2025
xbtmatt
xbtmatt reviewed Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider gating this entire PR by env var "ARENA_ENABLED", just a note for self

Base automatically changed from ECO-2660 to main January 29, 2025 22:42
@xbtmatt xbtmatt force-pushed the ECO-2664 branch 2 times, most recently from 463707b to 8d87721 Compare January 29, 2025 23:33
@xbtmatt xbtmatt force-pushed the ECO-2664 branch 2 times, most recently from c9d5be2 to e94fd62 Compare January 29, 2025 23:39
xbtmatt
xbtmatt reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing to fix: fixing the black background behind emojis when it loads

@CRBl69 CRBl69 requested a review from xbtmatt February 3, 2025 20:47
@xbtmatt xbtmatt changed the base branch from main to arena February 10, 2025 03:44
xbtmatt
xbtmatt approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing to note is that the fetchMarketStateByAddress calls can be combined, but I'll do it in another PR!

@xbtmatt xbtmatt enabled auto-merge (squash) February 10, 2025 04:06
@xbtmatt xbtmatt merged commit cd70d2c into arena Feb 10, 2025
7 checks passed
@xbtmatt xbtmatt deleted the ECO-2664 branch February 10, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xbtmatt xbtmatt

Assignees
No one assigned
Labels
urgency-high Please check first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CRBl69 @xbtmatt