-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-2492] Calculate the swap price client-side #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xbtmatt
commented
Nov 26, 2024
src/typescript/frontend/src/lib/hooks/queries/use-simulate-swap.ts
Outdated
Show resolved
Hide resolved
xbtmatt
commented
Nov 26, 2024
src/typescript/sdk/src/emojicoin_dot_fun/calculate-swap-price.ts
Outdated
Show resolved
Hide resolved
alnoki
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of hitting the Aptos Labs fullnode with a view function, we can run the
simulate_swap_inner
function client-side. This will lower the resources we consume from the fullnode API.useSimulateSwap
hook (or only use it as a backup)Testing
useSimulateSwap
always results in the same output as the calculation functionproduction
build or another build with the old logicChecklist