Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2436] Add Aptos API keys to the Aptos client anywhere we use it #374

Merged
merged 14 commits into from
Nov 19, 2024

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Nov 18, 2024

Description

Add the Aptos API keys to the environment variables and use it in the Aptos client class everywhere, including the sdk and the frontend and the docker container for e2e tests.

Resolve the key by the network, so we don't have to update environment variables for each build but rather provide them all at once, like so:

NEXT_PUBLIC_LOCAL_APTOS_API_KEY="" # Blank is fine for local, since it ignores it.
NEXT_PUBLIC_CUSTOM_APTOS_API_KEY="" # We only use `custom` for local as of right now, so same as above.
NEXT_PUBLIC_DEVNET_APTOS_API_KEY="AG-key1"
NEXT_PUBLIC_TESTNET_APTOS_API_KEY="AG-key2"
NEXT_PUBLIC_MAINNET_APTOS_API_KEY="AG-key3"

Testing

We use it everywhere now so it should fail in any SDK or frontend tests that use the Aptos client class.

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check all checkboxes from the linked Linear task?

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 2:13am
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 2:13am

@xbtmatt xbtmatt changed the title [ECO-2436] Add Aptos API keys to the Aptos client class (frontend *and* sdk) [ECO-2436] Add Aptos API keys to the Aptos client anywhere we use it Nov 18, 2024
@xbtmatt xbtmatt requested review from CRBl69 and alnoki and removed request for CRBl69 November 18, 2024 23:40
@alnoki alnoki added the urgency-high Please check first label Nov 19, 2024
@alnoki alnoki merged commit 0719b45 into main Nov 19, 2024
6 of 7 checks passed
@alnoki alnoki deleted the ECO-2436 branch November 19, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgency-high Please check first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants