Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2421] Add claim key config to AptosWalletAdapterProvider #362

Closed
wants to merge 2 commits into from
Closed

[ECO-2421] Add claim key config to AptosWalletAdapterProvider #362

wants to merge 2 commits into from

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Nov 17, 2024 •
edited
Loading

Description

  • Add claim key config to AptosWalletAdapterProvider

Testing

Test.

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check all checkboxes from the linked Linear task?

@xbtmatt xbtmatt requested a review from CRBl69 November 17, 2024 04:16
@vercel Vercel
Copy link

vercel bot commented Nov 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:21pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:21pm

@xbtmatt
Update package dependencies
d9463ec 
Add (possibly) optional APTOS_API_KEY to env.ts (not optional on mainnet)

Add claim key options to providers
@xbtmatt
Rebase with new code, remove old functionality
5e49973
@xbtmatt xbtmatt changed the base branch from main to qrcodes November 18, 2024 19:19
@alnoki alnoki added the urgency-medium Check after high urgency label Nov 18, 2024
@CRBl69
Copy link
Collaborator

CRBl69 commented Nov 25, 2024

Closing as feature is deemed not necessary anymore. Changes unrelated to the payment solution but necessary to the repo included in #410.

@CRBl69 CRBl69 closed this Nov 25, 2024
@alnoki alnoki deleted the ECO-2421 branch November 25, 2024 18:29
@CRBl69 CRBl69 restored the ECO-2421 branch November 25, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRBl69 CRBl69 Awaiting requested review from CRBl69

Assignees
No one assigned
Labels
urgency-medium Check after high urgency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xbtmatt @CRBl69 @alnoki