[ECO-2389] Render /launch as a static page
#335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CRBl69
requested changes
Nov 11, 2024
…till consider them geoblocked by default
alnoki
added
urgency-high
CRBl69
approved these changes
Nov 14, 2024
src/typescript/frontend/src/components/header/wallet-button/ConnectWalletButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Bogdan Crisan <[email protected]>
xbtmatt
added a commit
that referenced
this pull request
Nov 15, 2024
Co-authored-by: Bogdan Crisan <[email protected]>
xbtmatt
added a commit
that referenced
this pull request
Nov 15, 2024
Co-authored-by: Bogdan Crisan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can make
/launcha completely static page, making it faster to load, by making the geoblock check client-side. We'll assume the user is geoblocked while the geoblocked function check promise resolves.There may be a better way to do this, if this is too intrusive (assuming they're blocked when they're not), depending on how the banner appears.
const dynamic = "force-static"at the top of the fileTesting
Check the build logs and ensure it's marked as a statically generated page in Vercel
Checklist