Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2363] Fix page number wrong on search #323

Merged
merged 7 commits into from
Nov 12, 2024
Merged

[ECO-2363] Fix page number wrong on search #323

merged 7 commits into from
Nov 12, 2024

Conversation

CRBl69
Copy link
Collaborator

@CRBl69 CRBl69 commented Nov 4, 2024

Description

On search, the number of pages was not correct. Now it is.

Testing

Search for something, check page number.

@CRBl69 CRBl69 requested a review from xbtmatt November 4, 2024 12:50
@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 8:01pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 8:01pm

@alnoki alnoki added urgency-medium Check after high urgency size-small A small PR. This can be reviewed and merged fast. labels Nov 4, 2024
xbtmatt
xbtmatt reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@xbtmatt xbtmatt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reminder to fix the issue where the first number (e.g. 3 in 3/10) in the page numbers is wrong.

For example, if you're on the 3rd page and then search an emoji, it will still be on the 3rd page

@CRBl69 CRBl69 requested a review from xbtmatt November 12, 2024 19:56
@xbtmatt xbtmatt merged commit f78875d into main Nov 12, 2024
8 checks passed
@xbtmatt xbtmatt deleted the ECO-2363 branch November 12, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xbtmatt xbtmatt xbtmatt approved these changes

Assignees
No one assigned
Labels
size-small A small PR. This can be reviewed and merged fast. urgency-medium Check after high urgency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CRBl69 @xbtmatt @alnoki