[ECO-2354] Add slippage and gas on trading page #317
Merged
+324
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alnoki
reviewed
Oct 30, 2024
...typescript/frontend/src/components/pages/emojicoin/components/trade-emojicoin/SwapButton.tsx
Outdated
Show resolved
Hide resolved
CRBl69
added
urgency-high
xbtmatt
requested changes
Oct 31, 2024
There was a problem hiding this comment.
It looks like you have an infinite re-render issue somewhere, when I look at the preview page I get this:
Maximum update depth exceeded. This can happen when a component
repeatedly calls setState inside componentWillUpdate or
componentDidUpdate. React limits the number of nested updates to prevent
infinite loops.
|
@xbtmatt what page are you getting that on exactly ? I can't reproduce it. |
|
Nevermind, I fixed it. |
xbtmatt
reviewed
Nov 8, 2024
src/typescript/frontend/src/components/selects/trade-options/index.tsx
Outdated
Show resolved
Hide resolved
Try to center the stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the gear for settings and the gas display on the trading page.
Screenshots
Testing
See vercel.