[ECO-2280] Replace 00 on home page #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I vote "Option A1" |
xbtmatt
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to replace the confusing
00on the home page.Here are some options:
Option A0 - 🔥
Personal opinion: this one feels the most confusing to me. It seems like it's the market name to me.
Option A1 - HOT 🔥
Personal opition: not a fan of the emoji, but this is the best compromise between having and emoji and clarity.
Option A2 - HOT RIGHT NOW 🔥
Personal opinion: maybe a bit too much.
Option A3 - FEATURED 🔥
Personal opition: just like option A1, but "featured" might give the false idea that the market is somehow officially endorsed.
Option B1 - HOT
Personal opinion: I like the look, very clean, but not very visible.
Option B2 - HOT RIGHT NOW
Personal opinion: sometimes, you don't need a reason to hate something.
Option B3 - FEATURED
Personal opinion: Looks the cleanest out of them all, but has the endorsement issue.