[ECO-1955] Update loading animation with hearts #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xbtmatt
reviewed
Oct 9, 2024
There was a problem hiding this comment.
As discussed on call, let's make sure the emojis are all centered for the one that the other emojis are circling.
You can probably visually test this easily by cycling through different random emojis really fast, and seeing which ones change the overall position/size of the wrapper div
Ideally we'll have custom css for poorly fitting emojis. If this is too complicated for all the different emoji picker sets (Apple, Windows, Linux, etc) we can just use Apple emojis
CRBl69
added
urgency-medium
xbtmatt
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the loading animation to match the general theme of emojicoin.fun.
It uses a cool animation with colored hearts.
Testing
See vercel preview.
Go to
/loadingto see the loading animation endlessly.Checklist