[ECO-2244] Add js/ts linting to pre-commit (#293)

econia-labs · Oct 16, 2024 · f1a02ef · f1a02ef
1 parent 9518001
commit f1a02ef
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 2 deletions.
diff --git a/.github/workflows/pre-commit.yaml b/.github/workflows/pre-commit.yaml
@@ -7,6 +7,7 @@
 env:
   POETRY_VERSION: '1.8.2'
   PYTHON_VERSION: '3.10'
+  TS_DIR: 'src/typescript'
 jobs:
   pre-commit:
     runs-on: 'ubuntu-latest'
@@ -20,6 +21,14 @@ jobs:
       run: |
         sudo apt-get update
         sudo apt-get install -y libdw-dev
+    - uses: 'actions/setup-node@v4'
+      with:
+        node-version-file: '${{ env.TS_DIR }}/.node-version'
+        registry-url: 'https://registry.npmjs.org'
+    - uses: 'pnpm/action-setup@v4'
+      with:
+        package_json_file: '${{ env.TS_DIR }}/package.json'
+    - run: 'cd ${{ env.TS_DIR }} && pnpm i'
     - name: 'Cache Poetry Install'
       uses: 'actions/cache@v3'
       with:

diff --git a/cfg/pre-commit-config.yaml b/cfg/pre-commit-config.yaml
@@ -109,6 +109,16 @@ repos:
     name: 'mypy'
     types:
     - 'python'
+  -
+    entry: |
+      pnpm run lint
+    files: 'src/typescript'
+    id: 'pnpm'
+    language: 'node'
+    name: 'lint typescript'
+    pass_filenames: false
+    types:
+    - 'directory'
   repo: 'local'
 -
   hooks:

diff --git a/src/typescript/frontend/package.json b/src/typescript/frontend/package.json
@@ -96,7 +96,7 @@
     "e2e:frontend": "playwright test --project=firefox",
     "format": "pnpm _format --write",
     "format:check": "pnpm _format --check",
-    "lint": "eslint -c .eslintrc.js --ext .js,.jsx,.ts,.tsx .",
+    "lint": "eslint --max-warnings=0 -c .eslintrc.js --ext .js,.jsx,.ts,.tsx .",
     "lint:fix": "pnpm run lint --fix",
     "playwright:install": "playwright install --with-deps",
     "pre-commit": "pnpm run pre-commit:install && pnpm run pre-commit:run",

diff --git a/src/typescript/sdk/package.json b/src/typescript/sdk/package.json
@@ -59,7 +59,7 @@
     "e2e:testnet": "pnpm load-test-env -v NO_TEST_SETUP=true -- pnpm jest tests/e2e/queries/testnet",
     "format": "pnpm _format --write",
     "format:check": "pnpm _format --check",
-    "lint": "eslint 'src/**/*.ts' 'tests/**/*.ts' -c .eslintrc.js",
+    "lint": "eslint --max-warnings=0 'src/**/*.ts' 'tests/**/*.ts' -c .eslintrc.js",
     "lint:fix": "pnpm lint --fix",
     "pre-commit": "pnpm run pre-commit:install && pnpm run pre-commit:run",
     "pre-commit:install": "pre-commit install -c ../../../cfg/pre-commit-config.yaml",