Add an alternative way of implementing Tauchen's method to make_tauchen_ar1()

[QingyuanFang]

By Qingyuan Fang

Please ensure your pull request adheres to the following guidelines:

• Tests for new functionality/models or Tests to reproduce the bug-fix in code.
• Updated documentation of features that add new functionality.
• Update CHANGELOG.md with major/minor changes.

[mnwhite]

Ruff is mad at two lines with improper whitespace, but otherwise this passes checks. This is functionality that we want, as it addresses true truncated processes, rather than those that are truncated as a matter of approximation.

Should probably add a test using the new feature, and do some sanity checks on its results.

[llorracc]

@mnwhite perhaps you could explain to what we mean by "a test using the new feature, and a sanity check on the results." Like, presumably, showing that the two methods get very close as the number of gridpoints increases?

[mnwhite]

Yes, but that was mostly a note to myself, and an indicator that the PR had been seen. I'll write more in the morning.

…

On Mon, Apr 15, 2024, 10:56 PM Christopher Llorracc Carroll < ***@***.***> wrote: @mnwhite <https://github.com/mnwhite> perhaps you could explain to what we mean by "a test using the new feature, and a sanity check on the results." Like, presumably, showing that the two methods get very close as the number of gridpoints increases? — Reply to this email directly, view it on GitHub <#1409 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKRAFIC6GTPK45SKAXP22TY5SHPRAVCNFSM6AAAAABGFW2BVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJYGE2DCMZXGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[llorracc]

@QingyuanFang,

Our Econ-ARK project manager has assigned me to complete this PR. Could you take a look and give me a sense of what we need to do to get it over the line? Probably at least a notebook to document it...

[llorracc]

Why did you close it? It would be useful to have this functionality ...

…

On Thu, Jan 23, 2025 at 7:21 PM Qingyuan Fang ***@***.***> wrote: Closed #1409 <#1409>. — Reply to this email directly, view it on GitHub <#1409 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKCK76JKT6FEQRAXTKUM2L2MGBQDAVCNFSM6AAAAABVYLLMSGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGA2TCNZTGQ2TQNQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

-- - Chris Carroll

[mnwhite]

I don't think we need a notebook, just a test. On Thu, Jan 23, 2025, 7:35 PM Christopher Llorracc Carroll < ***@***.***> wrote:

…

Why did you close it? It would be useful to have this functionality ... On Thu, Jan 23, 2025 at 7:21 PM Qingyuan Fang ***@***.***> wrote: > Closed #1409 <#1409>. > > — > Reply to this email directly, view it on GitHub > <#1409 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAKCK76JKT6FEQRAXTKUM2L2MGBQDAVCNFSM6AAAAABVYLLMSGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGA2TCNZTGQ2TQNQ> > . > You are receiving this because you were assigned.Message ID: > ***@***.***> > -- - Chris Carroll — Reply to this email directly, view it on GitHub <#1409 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKRAFNVT7VWX436MRSGIR32MGDFFAVCNFSM6AAAAABVYLLMSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGI4TONRUHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[llorracc]

Well, then, reopen it and make the comment that we just need a test. On Thu, Jan 23, 2025 at 7:41 PM Matthew N. White ***@***.***> wrote:

…

I don't think we need a notebook, just a test. On Thu, Jan 23, 2025, 7:35 PM Christopher Llorracc Carroll < ***@***.***> wrote: > Why did you close it? It would be useful to have this functionality ... > > > On Thu, Jan 23, 2025 at 7:21 PM Qingyuan Fang ***@***.***> > wrote: > > > Closed #1409 <#1409>. > > > > — > > Reply to this email directly, view it on GitHub > > <#1409 (comment)>, or > > unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AAKCK76JKT6FEQRAXTKUM2L2MGBQDAVCNFSM6AAAAABVYLLMSGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGA2TCNZTGQ2TQNQ> > > > . > > You are receiving this because you were assigned.Message ID: > > ***@***.***> > > > > > -- > - Chris Carroll > > — > Reply to this email directly, view it on GitHub > <#1409 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/ADKRAFNVT7VWX436MRSGIR32MGDFFAVCNFSM6AAAAABVYLLMSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGI4TONRUHE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#1409 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKCK75V6FNAYD33JYHXCB32MGD4BAVCNFSM6AAAAABVYLLMSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGMYDGNZTGI> . You are receiving this because you were assigned.Message ID: ***@***.***>

-- - Chris Carroll