Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 북마크 등록 API 추가 #65

Merged
merged 7 commits into from
Jan 11, 2025
Merged

[Feat] 북마크 등록 API 추가 #65

merged 7 commits into from
Jan 11, 2025

Conversation

uuujini
Copy link
Member

@uuujini uuujini commented Jan 7, 2025

📌 관련 이슈

✨ PR 내용

  • 스터디별 북마크 등록을 위한 기능입니다.

📚 레퍼런스 혹은 궁금한 사항들

  • 지난 컨벤션 회의에서 서비스단 파일은 도메인 폴더에 관리되면 좋겠다고 하여 기존 bookmark/service 폴더에 존재하던 파일의 위치를 domain 폴더로 변경하였습니다! (@homebdy)
  • 개별적인 시스템 환경 문제라고 생각하여 .DS_Store 시스템 파일 삭제 커밋을 해당 PR에 포함시켰습니다!

📸 스크린샷(선택)

@uuujini uuujini added the enhancement New feature or request label Jan 7, 2025
@uuujini uuujini requested a review from wnsvy607 January 7, 2025 07:34
@uuujini uuujini self-assigned this Jan 7, 2025
wnsvy607
wnsvy607 previously approved these changes Jan 11, 2025
Copy link
Contributor

@wnsvy607 wnsvy607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서비스에 이미 북마크가 됐는지 검증하는 부분과 북마크 카운트 증가시키는 부분 잘 추가하신 것 같습니다.

LGTM 👍

@wnsvy607 wnsvy607 merged commit 89679aa into develop Jan 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants