Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 스터디 지원 결과에 따른 가입 정보 자동 반영 #48

Merged
merged 7 commits into from
Dec 20, 2024
Merged

[Fix] 스터디 지원 결과에 따른 가입 정보 자동 반영 #48

merged 7 commits into from
Dec 20, 2024

Conversation

uuujini
Copy link
Member

@uuujini uuujini commented Dec 17, 2024

📌 관련 이슈

✨ PR 내용

  • 스터디 지원 승인/모집 시 가입 정보에 자동 등록
  • 스터디 모집/시작/종료 날짜 검증 로직 추가
  • 가입 종료 사유 데이터 형식 수정(enum -> String)
  • 스터디 지원 반려 시 반려 사유 포함하도록 수정

📚 레퍼런스 혹은 궁금한 사항들

  • Application<->Enrollment 관련 이슈로 묶다 보니 PR 단위가 커졌습니다.. 다음부터 기능별로 나눠서 올리겠습니다!

📸 스크린샷(선택)

@uuujini uuujini added the bug Something isn't working label Dec 17, 2024
@uuujini uuujini requested a review from Moveuk December 17, 2024 18:05
@uuujini uuujini self-assigned this Dec 17, 2024
@uuujini uuujini changed the title [FIX] 스터디 지원 결과에 따른 가입 정보 자동 반영 [Fix] 스터디 지원 결과에 따른 가입 정보 자동 반영 Dec 17, 2024
Moveuk
Moveuk approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Moveuk Moveuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘작성해주셔서 읽기가 편하네요! 고생하셨어요!

src/main/java/com/join/core/enrollment/domain/Enrollment.java Show resolved Hide resolved
src/main/java/com/join/core/enrollment/constant/EnrollmentStatus.java Show resolved Hide resolved
@uuujini uuujini merged commit 205f1ea into develop Dec 20, 2024
1 check passed
@uuujini uuujini deleted the fix/application branch December 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moveuk Moveuk Moveuk approved these changes

Assignees

@uuujini uuujini

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uuujini @Moveuk