-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the import issue #317 #318
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #318 +/- ##
===========================================
+ Coverage 80.79% 87.14% +6.34%
===========================================
Files 100 42 -58
Lines 8123 5148 -2975
===========================================
- Hits 6563 4486 -2077
+ Misses 1560 662 -898 ☔ View full report in Codecov by Sentry. |
Hi Yordan @itsgifnotjiff , thanks for the fix! I'd be happy to approve and merge this PR, but would it be possible to sign the CLA before we can merge? |
Sure thing, sorry about this. I just need to figure out what I am doing wrong or where to sign it. |
I signed the CLA so hopefully it detects it and you can merge :) |
Hi @itsgifnotjiff, unfortunately, it doesn’t seem like the CLA recognised the signature. We think it’s possible the email you committed with is not the same as your GitHub email. Would it maybe be possible to try to add the email associated with the commit as secondary GitHub email? Thank you and sorry about the inconvenience! |
@mathleur you were right, I am sorry for all of this. Now it seems all the checks pass. |
Great! Yes, thank you for your help! I'll approve the PR now :) |
Minor readme.md fix but it's weird to have to import
polytope_feature
instead ofpolytope
, so it might be worth a looksee from someone smarter than me :)