Sanitise: Fix rescoping of symbols for nested associates #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When nested associates are about to be removed, we need to account for that when updating the symbol-scope (a priori). This new logic does this by counting out the nested associates and picking the appropriate one, according to the septh of the symbol in the nest. I've extended the stat-func test, where this most often triggers.
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/470/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
==========================================
- Coverage 93.35% 93.35% -0.01%
==========================================
Files 223 223
Lines 41428 41434 +6
==========================================
+ Hits 38676 38681 +5
- Misses 2752 2753 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reuterbal
approved these changes
Jan 10, 2025
reuterbal
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nested associates are about to be removed, we need to account for that when updating the symbol-scope (a priori). This new logic does this by counting out the nested associates and picking the appropriate one, according to the septh of the symbol in the nest.
I've extended the stat-func test, where this most often triggers.
Note, this looks like a recurrence of the problem in #439 and hopefully should address issue #459 (@ecossevin to confirm).