Frontend: Final removal of OFP frontend

[mlange05]

o7

[github-actions]

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/469/index.html

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (b0a2344) to head (730399b).
Report is 20 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   93.35%   96.03%   +2.67%     
==========================================
  Files         223      222       -1     
  Lines       41428    40068    -1360     
==========================================
- Hits        38676    38480     -196     
+ Misses       2752     1588    -1164     

Flag	Coverage Δ
lint_rules	96.39% <ø> (ø)
loki	96.02% <100.00%> (+2.71%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[reuterbal]

Thanks, looks good.

However, as mentioned in a comment during the deprecation (#406 (comment)) we need to now also remove the routines that were only kept around for OFP. Because they have not had code coverage after the deprecation, this doesn't show up at this point anymore.

Could you take care of the checklist in the above linked comment, please?

[mlange05]

Could you take care of the checklist in the above linked comment, please?

Yes, thanks for the pointer, I had forgotten about that. I've removed the main utilities and the test now - the false positives I think we want to address once we expand more low-level unit testing of the interior IR nodes and scoping behaviour.

[reuterbal]

Great, thanks. Agreed on the false positives, they should stay in.
Any particular reason for keeping the disc-cached utility? https://github.com/ecmwf-ifs/loki/blob/main/loki/tools/files.py#L186-L227
It is currently not being tested: https://app.codecov.io/gh/ecmwf-ifs/loki/pull/469/blob/loki/tools/files.py#L186

[mlange05]

Great, thanks. Agreed on the false positives, they should stay in. Any particular reason for keeping the disc-cached utility?

Ah, good catch, I had removed the option, but not the utility. I've done that now (top commit), and rebased over main.

[reuterbal]

Many thanks, looks good to me now!

Now comes also with a nice uplift of the code coverage to >96%!
(The Github check for codecov is stuck somehow but will override upon merge)