Loki-transform: Remove custom entry point options #465
+26
−465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlange05
changed the title
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/465/index.html |
mlange05
force-pushed
the
naml-remove-custom-entry-points
branch
2 times, most recently
from
bc4ac13 to
2f21edd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage 96.03% 96.03%
=======================================
Files 226 226
Lines 40581 40581
=======================================
Hits 38972 38972
Misses 1609 1609
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mlange05
force-pushed
the
naml-remove-custom-entry-points
branch
from
c81485b to
9e9169b
Compare
mlange05
force-pushed
the
naml-remove-custom-entry-points
branch
from
9e9169b to
e3987b9
Compare
|
This should now be ready, but still relies on some downstream dev branches. I'll put this into Review mode, once these are merged and I've removed the respective re-pointing commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This sits on top of PR #464 and requires CLOUDSC CLOUDSC PR 106 to be merged first.Note: For testing only at this stage.Following the conversion to config-file based pipelines, this PR now removes all the custom entry point options under
loki-transform.py convertand their associated use in CMake macros. It also removes the now unusedloki_transform_convertentry point.