Loki: Turn test sub-directories into sub-pacakges #447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make test integration cleaner and avoids eventual namespace clashes in the future. It also now runs the linter over tests, without exporting test symbols as part of
from loki import *
(please double-check this).Note, the other half of this is hidden in PR #446 , where this was necessary to avoid namespace clashes in tests.
EDIT: Looks like I have to leave
loki.lint.tests
untouched, as the introduction of the test sub-packages makes the dynamicrules
imports go haywire. I leave that for a follow-on PR.