Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: Pin pymbolic version to 2022.2 due to upstream incompatibility #434

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mlange05
Copy link
Collaborator

Upstream update to Pymbolic v2024.1 is causing issues in ecWAM regression suite that need separate investigation. Pinning to known-good version with this.

@mlange05 mlange05 requested a review from reuterbal November 11, 2024 09:11
@reuterbal reuterbal changed the title Loki: Pin pmbolic version to 2022.2 due to upstream incompatibility Loki: Pin pymbolic version to 2022.2 due to upstream incompatibility Nov 11, 2024
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/434/index.html

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (b12c834) to head (812bd76).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   93.13%   93.14%           
=======================================
  Files         200      200           
  Lines       39702    39702           
=======================================
+ Hits        36978    36979    +1     
+ Misses       2724     2723    -1     
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 93.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! Confirmed that this is indeed needed right now and pinning the version restores functionality.

@reuterbal reuterbal added the ready to merge This PR has been approved and is ready to be merged label Nov 11, 2024
@reuterbal reuterbal merged commit 15d4a3f into main Nov 11, 2024
13 checks passed
@reuterbal reuterbal deleted the naml-fix-pymbolic-2022.2 branch November 11, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants