-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continued: F2C/CUDA transpilation #424
Conversation
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/424/index.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 93.16% 93.19% +0.02%
==========================================
Files 205 205
Lines 39832 39933 +101
==========================================
+ Hits 37109 37214 +105
+ Misses 2723 2719 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good. I would like to change the naming of the new methods for InlineCall. I got bitten by the difference in behaviour and we should make this explicit.
…analog to CallStatement's)
…access via variable_map
…nvert (inline) call names, kwargs to args, ...
99ab5ae
to
c018c04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the changes! I think this looks ready now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Thanks both for the diligent review and API consistency changes. GTG form me
Mostly related to nested/multi-level kernel calls:
__device__
prefix<call/function name>_c