Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued: F2C/CUDA transpilation #424

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

MichaelSt98
Copy link
Collaborator

Mostly related to nested/multi-level kernel calls:

  • __device__ prefix
  • kwargs to args (also for inline calls)
  • call name adaptation -> <call/function name>_c
  • ...

Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/424/index.html

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 99.09910% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.19%. Comparing base (358fb60) to head (c018c04).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
loki/transformations/single_column/scc_cuf.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   93.16%   93.19%   +0.02%     
==========================================
  Files         205      205              
  Lines       39832    39933     +101     
==========================================
+ Hits        37109    37214     +105     
+ Misses       2723     2719       -4     
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 93.14% <99.09%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. I would like to change the naming of the new methods for InlineCall. I got bitten by the difference in behaviour and we should make this explicit.

loki/transformations/transpile/fortran_c.py Show resolved Hide resolved
loki/expression/symbols.py Outdated Show resolved Hide resolved
loki/expression/symbols.py Outdated Show resolved Hide resolved
loki/expression/symbols.py Outdated Show resolved Hide resolved
@MichaelSt98 MichaelSt98 force-pushed the nams-continued-effort-cuda-transpilation branch from 99ab5ae to c018c04 Compare November 12, 2024 11:47
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the changes! I think this looks ready now!

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks both for the diligent review and API consistency changes. GTG form me :shipit:

@reuterbal reuterbal added the ready to merge This PR has been approved and is ready to be merged label Nov 19, 2024
@reuterbal reuterbal merged commit b88920c into main Nov 19, 2024
13 checks passed
@reuterbal reuterbal deleted the nams-continued-effort-cuda-transpilation branch November 19, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants