-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PAPI functionality to Dr Hook #18
Conversation
… papi implementation
src/fiat/drhook/drhook_papi.c
Outdated
int number; | ||
int j=1; | ||
#ifdef _OPENMP | ||
j=safe_thread_num(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
safe_thread_num()
normally returns 0 when _OPENMP
is not defined.
So I thought it seems redundant to have j=safe_thread_num()
wrapped with #ifdef _OPENMP
.
However then the default value j=1
would become j=0
.
That would bypass the further j==k
condition when nthreads=1
as is the case without _OPENMP
defined.
Is that the intention, why j=1
?
For sake of development, add |
@MartynF any occurrence of |
Did fiat-print-bindings require OpenMP in C? It looks like it has pragmas! |
In version 7.... which isn't distributed with majority use OS's including current HPC right now .... |
Yes it does, but this is a standalone executable that does not even link to fiat.
Right let's keep it then. Thanks for clarifying. |
I would like to get this merged as it has been a while. |
I will take this PR up further now. |
@ioanhadade @MartynF I have created a new PR #26 from the latest develop branch. Please check it still satisfies, and let's continue discussion there. I will close this PR at the moment. Thanks @MartynF for this nice feature! |
No description provided.