Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #4

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

PeterGHill
Copy link
Collaborator

No description provided.

@RCHG
Copy link
Collaborator

RCHG commented Jan 6, 2025

Hello Peter, I saw today this pull-request. I will integrate in Master branch as soon as possible. Thanks.

@PeterGHill
Copy link
Collaborator Author

Hi Ramiro,

Thanks for this.

I'm not sure how much you want to be involved with this repository in the future? I appreciate managing this code is not part of your job any more, but would be great to have you involved if you would like to be.

I was not necessarily expecting you to do the commit. It's a fairly minor change which just consists of adding a new file, so I can do myself if necessary. If it's something you want to do then that would be great! It's always good to have a second pair of eyes on the code :-) There's no rush to do this, but let me know either way.

@RCHG
Copy link
Collaborator

RCHG commented Feb 3, 2025

Hello Peter,

This code is used/part of CAMS developments in which I am involved (in CAMS projects, beyond some collaborations with external research groups). This means that at least I will have to use the code and perform eventually some improvements useful for AER-scheme in the IFS/OpenIFS code (maybe in the engine part).

Your improvement was not changing the main workflow of previous users (I guess) so I did not integrated yet in the master branch. But I will do. I guess that at this moment you are working fine with your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants