removed unnecessary feature from zenoh-plugin-trait to avoid false compatibility errors #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted compatibilty errors
|
PR missing one of the required labels: {'bug', 'new feature', 'breaking-change', 'internal', 'enhancement', 'dependencies', 'documentation'} |
Mallets
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "default" feature in the crate is dummy, but it causes plugin incompatibility diagnostic if plugin is built without "default-features = false" for this crate. Better to remove it to avoid such failures
This problem causes plugin incompatibility for zehoh-ts. It can be fixed on zenoh-ts level, but better to fix the root cause