Merge Typescript API into eclipse-zenoh #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd options to get desired module behaviour
…xpress, add webpack for web example
… internal Zenoh functions to js
…d js, TODO wasm, add README
…op, need to figure out what happens
…ffer from JS to WASM working
…en plugin and frontend
Implement B64 encode payload
fuzzypixelz
reviewed
Oct 7, 2024
| * | ||
| * @returns Reply | ||
| */ | ||
| async receive(): Promise<Reply | RecvErr> { |
There was a problem hiding this comment.
I think this ought to throw an exception instead.
Only NTP64 can ensure timestamp uniqueness. RFC3339 is lossy. This reverts commit ccbfea8.
gabrik
reviewed
Oct 8, 2024
Comment on lines
+8
to
+10
| remote_api: { | ||
| "websocket_port": "10000", | ||
| }, |
There was a problem hiding this comment.
If TLS/mTLS is supported an example on how to configure it should be present in the config.
gabrik
reviewed
Oct 8, 2024
Co-authored-by: Mahmoud Mazouz <[email protected]>
gabrik
requested changes
Oct 21, 2024
According to the Eclipse Handbook, The copright header year is the year of the initial creation. I interpret this as the year in which the file was added to git. https://www.eclipse.org/projects/handbook/#ip-copyright-headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly large PR, To break it down and make it easier to consume.
zenoh-plugin-remote-apiIs a plugin thatRemoteAPIMsgenum and all sub enums and structures inside.This set of interface definitions are consumed by the Typescript bindings
zenoh-tsIs a set of bindings to the core Zenoh functions.Everything the user will interact with is exported via
/src/index.tsUnder the hood,
zenoh-tsopens a Websocket connection connecting to thezenoh-plugin-remote-apirunning on azenohdinstance and remotely manages resources.If the Websocket connection disconnects, the state (Publishers/Subscribers/Queryables) of that websocket connection is dropped by the plugin and a new session on the front end will have to be opened.
The interface files generated by the
zenoh-plugin-remote-apiare found inzenoh-ts/src/remote-api/interfaceAll files inside
zenoh-ts/src/remote-api/*are used to manage messages between the Websocket and the user facing API.This includes long living resources such as
Queryablesand callback basedSubscribers