Support different config for ROS_LOCALHOST_ONLY. #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'breaking-change', 'new feature', 'internal', 'documentation', 'dependencies', 'enhancement', 'bug'} |
evshary
force-pushed
the
fix_localhost_only
branch
from
9bdba97 to
8f2cc42
Compare
Signed-off-by: ChenYing Kuo <[email protected]>
evshary
force-pushed
the
fix_localhost_only
branch
from
8f2cc42 to
5fbe5b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After ROS 2 Iron, the config used in ROS_LOCALHOST_ONLY is changed a lot, and it will make zenoh-bridge-ros2dds unable to communicate with ROS node running in ROS_LOCALHOST_ONLY.
Update the config used in zenoh-bridge-ros2dds while running with ROS 2 Iron or later version
https://github.com/ros2/rmw_cyclonedds/blob/c9e7001e6bf5373bdf1931535354b52eeddb2053/rmw_cyclonedds_cpp/src/rmw_node.cpp#L1134