Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config utilities #14

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Config utilities #14

merged 7 commits into from
Dec 15, 2023

Conversation

DariusIMP
Copy link
Member

Adding config utilities to programmatically edit the Zenoh configuration.

@DariusIMP
Copy link
Member Author

@gabrik

gabrik
gabrik requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@gabrik gabrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a good starting point, but see the comments as there is room for improvement.

zenoh-kotlin/src/commonMain/kotlin/io/zenoh/Config.kt Show resolved Hide resolved
zenoh-kotlin/src/commonMain/kotlin/io/zenoh/Config.kt Outdated Show resolved Hide resolved
@DariusIMP
Copy link
Member Author

Tested mTLS on an Android app, it works fine.

gabrik
gabrik approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@gabrik gabrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zenoh-kotlin/src/commonMain/kotlin/io/zenoh/Config.kt Show resolved Hide resolved
@gabrik gabrik merged commit 7fd8fe6 into eclipse-zenoh:main Dec 15, 2023
2 checks passed
@DariusIMP DariusIMP deleted the config_utilities branch December 15, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrik gabrik gabrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DariusIMP @gabrik