The WebSocket client pool should not starve on connect error. #5438
+119
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
websocket-pool-should-not-starve-on-connect-error
branch
2 times, most recently
from
a61da31 to
1861820
Compare
Motivation: The client WebSocket pool implementation (which is not really a pool but instead a semaphore + a wait queue) does not decrement the semaphore when the connection fails to be established. Currently, no operation is done beside calling back the caller. As consequence, the wait queue fills with new requests and never satisfy them since. Changes: When the connection fails, the semaphore should be released and check the wait queue for pending requests.
vietj
force-pushed
the
websocket-pool-should-not-starve-on-connect-error
branch
from
1861820 to
c0da53c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The client WebSocket pool implementation (which is not really a pool but instead a semaphore + a wait queue) does not decrement the semaphore when the connection fail to be established.
Currently, no operation is done beside calling back the caller. As consequence, the wait queue fills with new requests and never satisfy them since.
Changes:
When the connection fails, the semaphore should be released and check the wait queue for pending requests.