[tycho-4.0.x] Fix stack overflow when workspace config folder contains bnd.bnd file #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if one places a bnd.bnd file in the config folder of the workspace (what seems to be somehow supported) then this is detected as a project and it tries to find a parent for that what results in the config folder to be considered as a parent and so on leading to stack overflow. This now detects the situation and throws an exception with a message indicating the cause of the problem. (cherry picked from commit 836452b)
Test Results 606 files ±0 606 suites ±0 4h 39m 13s ⏱️ + 34m 49s For more details on these errors, see this check. Results for commit ff8cd4b. ± Comparison against base commit 20d1c24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintotycho-4.0.x:Questions ?
Please refer to the Backport tool documentation