Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate configured folders from bnd to maven model #4673

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Feb 1, 2025

The user can define custom folders for output and sources, these are now propagated from the bnd config to the maven model.

FYI @chrisrueger

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Feb 1, 2025
@chrisrueger
Copy link
Contributor

chrisrueger commented Feb 1, 2025

I retested this PR with our build. still successfull ✅

Our folders in cnf/build.bnd are configured like this:

target-dir=generated${if;${driver;eclipse};;/${driver}}
bin=${target-dir}/classes
testbin=${target-dir}/test-classes

I also confirm ${driver} is picked up correctly:

image

@chrisrueger
Copy link
Contributor

chrisrueger commented Feb 1, 2025

Question: One thing I noticed is that mvn clean does not remove the target-dir defined via cnf/build-bnd.

This is how it looks after a mvn clean.

image

Copy link

github-actions bot commented Feb 1, 2025

Test Results

  606 files  ±0    606 suites  ±0   4h 0m 6s ⏱️ + 7m 51s
  434 tests ±0    427 ✅ +2   7 💤 ±0  0 ❌  - 2 
1 302 runs  ±0  1 280 ✅ +2  22 💤 ±0  0 ❌  - 2 

Results for commit 722bded. ± Comparison against base commit c87caeb.

♻️ This comment has been updated with latest results.

the user can define custom folders for output and sources, these are now
propagated from the bnd config to the maven model.
@laeubi laeubi force-pushed the propagate_folder_from_bnd branch from 356e9f5 to 722bded Compare February 1, 2025 16:34
@laeubi laeubi enabled auto-merge (rebase) February 1, 2025 16:34
@laeubi
Copy link
Member Author

laeubi commented Feb 1, 2025

Question: One thing I noticed is that mvn clean does not remove the target-dir defined via cnf/build-bnd

Should be fixed now!

@laeubi laeubi merged commit 9330061 into eclipse-tycho:main Feb 1, 2025
15 checks passed
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants